Add the visual WebMCP Workbench - #14
Open
TueJon wants to merge 1 commit into
Open
Conversation
TueJon
commented
Sep 6, 2026
TueJon
left a comment
Owner
Author
There was a problem hiding this comment.
P1 — skills/webmcpify/templates/webmcp-workbench.js:108 — normalizeExpected() accepts every manifest entry with an id, while the launcher passes the complete manifest.tools array. As a result, discovered (not yet approved) and terminal rejected tools are displayed as “Expected”/“Observed + expected”; if one is still registered, the Workbench also enables it and permits execution. That crosses the repository's manifest gate: rejected tools are explicitly excluded from every later phase, and this mode promises approved/integrated tools as Expected evidence. A manifest containing {id: "denied", status: "rejected"} is enough to reproduce the false Expected row.
Closure checklist:
- Filter launcher-provided manifest tools to entries that passed the gate; exclude at least
discoveredandrejected. - Apply the same status boundary when the template receives a manifest object directly, while preserving the documented explicit
expectedToolssubset API. - Add coverage proving rejected/discovered entries never appear as Expected or executable, including when a same-name live registration exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm run check— 40/40 passingnode tests/workbench-browser.mjs chromium firefox— desktop, tablet, 360px, dark/light, reduced-motion, simulated transport, native-shaped transport, lifecycle, contrast, focus, overflow, strict CSP, and Trusted Types passingSafety
The Workbench is never wired into a production entry or bundle. Simulated calls are visibly labeled and cannot change a manifest tool to
verified.